-
Notifications
You must be signed in to change notification settings - Fork 1.1k
No import suggestions for conditional implicit definitions #8827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
julienrf
added a commit
to scalacenter/dotty
that referenced
this issue
Jun 14, 2023
julienrf
added a commit
to scalacenter/dotty
that referenced
this issue
Jun 16, 2023
…found error We used to suggest imports for the outermost type of a chain of implicits. Now, we suggest imports for the `expectedType` of the underlying `NoMatchingImplicits`. Fixes scala#8827
julienrf
added a commit
to scalacenter/dotty
that referenced
this issue
Jun 19, 2023
…found error We used to suggest imports for the outermost type of a chain of implicits. Now, we suggest imports for the `expectedType` of the underlying `NoMatchingImplicits`. Fixes scala#8827
julienrf
added a commit
to scalacenter/dotty
that referenced
this issue
Jun 19, 2023
…found error We used to suggest imports for the outermost type of a chain of implicits. Now, we suggest imports for the `expectedType` of the underlying `NoMatchingImplicits`. Fixes scala#8827
julienrf
added a commit
to scalacenter/dotty
that referenced
this issue
Jun 19, 2023
…found error We used to suggest imports for the outermost type of a chain of implicits. Now, we suggest imports for the `expectedType` of the underlying `NoMatchingImplicits`. Fixes scala#8827
julienrf
added a commit
that referenced
this issue
Jun 20, 2023
…found error We used to suggest imports for the outermost type of a chain of implicits. Now, we suggest imports for the `expectedType` of the underlying `NoMatchingImplicits`. Fixes #8827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This issue is different from #8823 because it is related to conditional implicit definitions, not conversions.
Minimized code
https://scastie.scala-lang.org/eVaWn1IASUar0hFzfPpVTA
Output
Expectation
We should suggest importing
Implicits.orderFoo
.Note that with the same code, if we try to
summon[Order[Foo]]
we get the suggestion to importImplicits.orderFoo
.The text was updated successfully, but these errors were encountered: