Skip to content

Rework match type handling of invariant types #8778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OlivierBlanvillain opened this issue Apr 23, 2020 · 0 comments
Closed

Rework match type handling of invariant types #8778

OlivierBlanvillain opened this issue Apr 23, 2020 · 0 comments
Assignees
@OlivierBlanvillain
Labels
area:match-types

Comments

@OlivierBlanvillain
Copy link
Contributor

Currently we use !isSameType to conclude that two invariant types are disjoint, but as Guillaume pointed out that's incorrect. This should be reworked into a new def provablyNotEqual method in the same style than provablyDisjoint.
@OlivierBlanvillain OlivierBlanvillain self-assigned this Apr 23, 2020
odersky added a commit that referenced this issue May 29, 2020
@odersky
Merge pull request #9073 from dotty-staging/fix-8778
0540e5e 
 Fix #8778: Clarify comment in provablyDisjoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlivierBlanvillain OlivierBlanvillain

Labels
area:match-types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OlivierBlanvillain