Skip to content

setter generation for var in class generates wrong code #7296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aappddeevv opened this issue Sep 23, 2019 · 1 comment
Closed

setter generation for var in class generates wrong code #7296

aappddeevv opened this issue Sep 23, 2019 · 1 comment
Labels
itype:bug

Comments

@aappddeevv
Copy link

aappddeevv commented Sep 23, 2019 •
edited
Loading

https://gitter.im/lampepfl/dotty?at=5d88c6115d24375b3e075ca0

I'm claiming this generates the wrong code because it gives a warning under "-strict".

It appears that this warning pops up alot when -strict is set. I'm also getting these warnings on given instance declarations.
@smarter
Copy link
Member

smarter commented Sep 23, 2019

I think -strict should just not emit warnings for def foo_=, setters should be writable without using @alpha.

smarter added a commit that referenced this issue Sep 25, 2019
@smarter
Merge pull request #7316 from dotty-staging/fix-#7296
2bdec59 
Fix #7296: Don't flag setter names as operator names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
itype:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smarter @aappddeevv