Skip to content

VSCode does not highlight given in import list #7233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odersky opened this issue Sep 16, 2019 · 2 comments · Fixed by scala/vscode-scala-syntax#56
Closed

VSCode does not highlight given in import list #7233

odersky opened this issue Sep 16, 2019 · 2 comments · Fixed by scala/vscode-scala-syntax#56

Comments

@odersky
Copy link
Contributor

odersky commented Sep 16, 2019 •
edited
Loading

The new given import is like this:

import a.b.given
import a.b.{_, given}
import a.b.{given X}

Currently VSCode does not syntax-highlight the given in these positions.
@nicolasstucki
Copy link
Contributor

image

This was referenced Sep 17, 2019
Closed
Merged
nicolasstucki added a commit to scala/vscode-scala-syntax that referenced this issue Sep 17, 2019
@nicolasstucki
Fix #55: Add given imports syntax
666c463 
Highlight the `given` in imports as a keyword and names as type entities.

* As implemented in scala/scala3#7210
* Also fixes scala/scala3#7233
@nicolasstucki nicolasstucki mentioned this issue Sep 17, 2019
Merged
@nicolasstucki
Copy link
Contributor

@odersky could you have a look at scala/vscode-scala-syntax#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #55: Add given imports syntax scala/vscode-scala-syntax
2 participants
@odersky @nicolasstucki