-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Wrong overload resolution when expanding macro call #7110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like the issue is starts at this line. val d = qualType.findMember(name, pre).atSignature(sig) where
Which kind of looks correct except that the return type in the signature that we are looking for is |
The issue is that when we pickle, we see the signature from |
Do we need it before we can release RC18? |
I moved it on the next one! It is not a blocker. |
wip WIP wip
wip WIP wip
wip WIP wip
To avoid wrong member selection when unpickling we must have qualifiers that have the same type as when it was pickled. This implies that we cannot expand the holes durring unplickling as the expansion of a qualifier could have a more precise type. To be able to unpickle a hole without expanding it we must know it's type, hence it must be pickled. Once the pickled quote has been unpickled, we first replace all the type splices. After the types are properly set we expand all the term holes. Changes * Types of holes are pickled in TASTy * Pickled quotes are unpickled and after that the holes are expanded * Improved debugging info for unpickled quotes
To avoid wrong member selection when unpickling we must have qualifiers that have the same type as when it was pickled. This implies that we cannot expand the holes durring unplickling as the expansion of a qualifier could have a more precise type. To be able to unpickle a hole without expanding it we must know it's type, hence it must be pickled. Once the pickled quote has been unpickled, we first replace all the type splices. After the types are properly set we expand all the term holes. Changes * Types of holes are pickled in TASTy * Pickled quotes are unpickled and after that the holes are expanded * Improved debugging info for unpickled quotes
minimized code
Macro definition:
Use:
expectation
Overloading should work. Instead it reports:
If I remove the macro call it works (TASTy problem), if the
Symantics
is not parametric it also works. I don't think that it directly related to #7022 but it is definitely in the same area (@smarter WDYT?). BTW, the<no phase>
in the error is also a bug I assume.The text was updated successfully, but these errors were encountered: