Skip to content

Inline methods clash after erasure #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bishabosha opened this issue Jun 26, 2019 · 2 comments · Fixed by #8472
Closed

Inline methods clash after erasure #6750

bishabosha opened this issue Jun 26, 2019 · 2 comments · Fixed by #8472
Labels
stat:needs spec

Comments

@bishabosha
Copy link
Member

minimized code

inline def foo(i: => Int)  = ???
inline def foo(l: => Long) = ???

expectation

These should be able to exist in the same scope as Function0[Int] and Function0[Long] are only required at compiletime.

result

error [erasure]:

Double definition:
inline def foo(i: => Int): Nothing in package object package$package at line 1 and
inline def foo(l: => Long): Nothing in package object package$package at line 2
have the same type after erasure.
@nicolasstucki
Copy link
Contributor

Should the following also be accepted? And any other non erased type? Or should it be only an exception for by-name parameters?

inline def foo(i: () => Int)  = ???
inline def foo(l: () => Long) = ???

nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 9, 2019
@nicolasstucki
Fix scala#6750: Use semi-erased by name pameter signature
b8fce76 
Before `Erasure` the signatures will contain `=>X` instead of `Function0`. This makes signature
clashes of by-name parameters only show up after `Erasure`. This allows for `inline` methods to
have by-name parameter overloads.
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 9, 2019
@nicolasstucki
Fix scala#6750: Use semi-erased by name parameter signature
36b143e 
Before `Erasure` the signatures will contain `=>X` instead of `Function0`. This makes signature
clashes of by-name parameters only show up after `Erasure`. This allows for `inline` methods to
have by-name parameter overloads.
@nicolasstucki nicolasstucki mentioned this issue Jul 11, 2019
Closed
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 11, 2019
@nicolasstucki
Fix scala#6750: Use semi-erased by name parameter signature
197d43e 
Before `Erasure` the signatures will contain `=>X` instead of `Function0`. This makes signature
clashes of by-name parameters only show up after `Erasure`. This allows for `inline` methods to
have by-name parameter overloads.
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 15, 2019
@nicolasstucki
Fix scala#6750: Use semi-erased by name parameter signature
f8b8a0f 
Before `Erasure` the signatures will contain `=>X` instead of `Function0`. This makes signature
clashes of by-name parameters only show up after `Erasure`. This allows for `inline` methods to
have by-name parameter overloads.
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 15, 2019
@nicolasstucki
Fix scala#6750: Use semi-erased by name parameter signature
4e62869 
Before `Erasure` the signatures will contain `=>X` instead of `Function0`. This makes signature
clashes of by-name parameters only show up after `Erasure`. This allows for `inline` methods to
have by-name parameter overloads.
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 16, 2019
@nicolasstucki
Fix scala#6750: Use semi-erased by name parameter signature
8f20120 
Before `Erasure` the signatures will contain `=>X` instead of `Function0`. This makes signature
clashes of by-name parameters only show up after `Erasure`. This allows for `inline` methods to
have by-name parameter overloads.
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 22, 2019
@nicolasstucki
Fix scala#6750: Use semi-erased by name parameter signature
7795cb7 
Before `Erasure` the signatures will contain `=>X` instead of `Function0`. This makes signature
clashes of by-name parameters only show up after `Erasure`. This allows for `inline` methods to
have by-name parameter overloads.
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 30, 2019
@nicolasstucki
Fix scala#6750: Use semi-erased by name parameter signature
e7f171c 
Before `Erasure` the signatures will contain `=>X` instead of `Function0`. This makes signature
clashes of by-name parameters only show up after `Erasure`. This allows for `inline` methods to
have by-name parameter overloads.
@nicolasstucki nicolasstucki removed their assignment Aug 29, 2019
@nicolasstucki
Copy link
Contributor

nicolasstucki commented Mar 8, 2020 •
edited
Loading

With the new inline parameter semantics, we should use inline instead of by name. This fixed the issue.

inline def foo(inline i: Int)  = ???
inline def foo(inline l: Long) = ???

nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Mar 8, 2020
@nicolasstucki
Fix scala#6750: Add regression test
4aa5036
@nicolasstucki nicolasstucki linked a pull request Mar 8, 2020 that will close this issue
Fix #6750: Add regression test #8472
Merged
liufengyun added a commit that referenced this issue Mar 9, 2020
@liufengyun
Merge pull request #8472 from dotty-staging/fix-#6750
15e95c2 
Fix #6750: Add regression test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stat:needs spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6750: Add regression test dotty-staging/dotty
2 participants
@nicolasstucki @bishabosha