Skip to content

Incorrect scripted test for compiler plugin #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liufengyun opened this issue May 4, 2019 · 0 comments · Fixed by #6453
Closed

Incorrect scripted test for compiler plugin #6452

liufengyun opened this issue May 4, 2019 · 0 comments · Fixed by #6453
Assignees
@liufengyun
Labels
itype:bug

Comments

@liufengyun
Copy link
Contributor

As discovered in sbt/sbt#4641, the scripted test for compiler plugin has a problem:

  • The plugin specifies that it runs before Staging and after Pickler

The requirement cannot be satisfied, thus an error is reported by the compiler -- which is the case in sbt/sbt#4641.

However, the scripted test failed to report the conflict -- it mistook the plugin-ordering error as an expected compilation error reported by the plugin.
@liufengyun liufengyun self-assigned this May 4, 2019
liufengyun added a commit to dotty-staging/dotty that referenced this issue May 4, 2019
@liufengyun
Fix scala#6452: capture plugin ordering conflict with a pos projct
8c1344d
@liufengyun liufengyun mentioned this issue May 4, 2019
Merged
liufengyun added a commit that referenced this issue May 6, 2019
@liufengyun
Merge pull request #6453 from dotty-staging/fix-6452
6429f7c 
Fix #6452: capture plugin ordering conflict with a pos project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liufengyun liufengyun

Labels
itype:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6452: capture plugin ordering conflict with a pos project dotty-staging/dotty
1 participant
@liufengyun