Skip to content

Context queries: Ambiguity between given argument and call to apply() #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eichholz opened this issue Feb 21, 2019 · 0 comments
Closed

Context queries: Ambiguity between given argument and call to apply() #5966

eichholz opened this issue Feb 21, 2019 · 0 comments
Labels
area:implicits related to implicits itype:question

Comments

@eichholz
Copy link

Given a function definition

def foo = given (v: Int) => (x: Int) => v + x
implied myInt for Int = 4

Both foo.apply(7) and (foo given 4)(7) works fine, but foo(7) fails to compile (method apply in trait ImplicitFunction1 does not take more parameters).

Tested with Dotty 0.13.0-RC1 and 0.14.0-bin-20190220-60c4bf8-NIGHTLY.
odersky added a commit to dotty-staging/dotty that referenced this issue Feb 22, 2019
@odersky
Fix scala#5966: Narrow criterion for when we have an inserted apply
b205591 
`insertApplyOrImplicit` checks whether we already have an inserted apply
in order to prevent an infinite insertion sequence. This criterion should
be restricted to just look at Select nodes. Once an inserted `apply`
is in fact applied it should not count anymore.

Also: Fix printing of FunProtos for "given" arguments.
smarter added a commit that referenced this issue Feb 22, 2019
@smarter
Merge pull request #5973 from dotty-staging/fix-#5966
b539b34 
Fix #5966: Narrow criterion for when we have an inserted apply
odersky added a commit to dotty-staging/dotty that referenced this issue Mar 17, 2019
@odersky
Test case for scala#5966
70dca88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:implicits related to implicits itype:question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liufengyun @eichholz