Skip to content

Regression: Lifted inner method tries to use this #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smarter opened this issue May 16, 2015 · 1 comment
Closed

Regression: Lifted inner method tries to use this #580

smarter opened this issue May 16, 2015 · 1 comment

Comments

@smarter
Copy link
Member

smarter commented May 16, 2015

This is exactly the same issue than #545, it was fixed in b0856fe but in the same pull request 32a7004 caused a regression.
In the example from #545, the enclosing class is the module class Test$ and the top class is also the module class Test$, so the test encClass.isProperlyContainedIn(topClass) fails.

Assigned to @DarkDimius .

smarter added a commit to smarter/dotty that referenced this issue May 19, 2015
DarkDimius added a commit that referenced this issue May 21, 2015
Fix #580: use isContainedIn to support cases where the enclosing class is also the top-level class
@odersky odersky reopened this May 29, 2015
@odersky
Copy link
Contributor

odersky commented May 29, 2015

The fix causes the build to fail. ClassPath does not compile anymore. This is what I have been seeing all along. It shows the value of a test infrastructure we can rely on. Without it we are flying blind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants