Skip to content

Please revert the {pos,run}-separate-compilation changes #5565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odersky opened this issue Dec 4, 2018 · 0 comments
Closed

Please revert the {pos,run}-separate-compilation changes #5565

odersky opened this issue Dec 4, 2018 · 0 comments
Assignees
@nicolasstucki
Labels
stat:fix available

Comments

@odersky
Copy link
Contributor

odersky commented Dec 4, 2018 •
edited
Loading

I believe splitting out separate compilation into new directories was done so that we would not get pickler failures when we compile all of pos/run. This imposes a tax on everyone using the test framework because things will be misclassified. In particular everyone coming from Scala-2, since they don't have a structure like this.

Would it not be far simpler if the pickling tests skipped all tests that were directories? That's maybe a two-line change in the test framework vs a constant hassle for its users.
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Dec 5, 2018
@nicolasstucki
Fix scala#5565: Revert the {pos,run}-separate-compilation changes
068c1ef
nicolasstucki added a commit that referenced this issue Dec 7, 2018
@nicolasstucki
Merge pull request #5571 from dotty-staging/fix-#5565
3e555e9 
Fix #5565: Revert the {pos,run}-separate-compilation changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasstucki nicolasstucki

Labels
stat:fix available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@odersky @nicolasstucki @allanrenucci