Skip to content

IDE: Consider fuzzy-search in completion #5507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Duhemm opened this issue Nov 23, 2018 · 1 comment · Fixed by #19850
Closed

IDE: Consider fuzzy-search in completion #5507

Duhemm opened this issue Nov 23, 2018 · 1 comment · Fixed by #19850
Labels
area:ide itype:enhancement
Milestone
3.5.0

Comments

@Duhemm
Copy link
Contributor

Duhemm commented Nov 23, 2018

Currently, we filter completion candidates that match the prefix that the user has written. We should try to do fuzzy search.

Note for later: we should consider doing fuzzy search instead (like what we do in https://github.com/lampepfl/dotty/blob/master/compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala#L338 (scalac implementation: scala/scala#6711))

Originally posted by @smarter in #5476
@kubukoz
Copy link
Contributor

kubukoz commented Feb 5, 2023

@abgruszecki hey, I found this issue while looking at scalameta/metals#4656 - I believe the completions are still limited in their fuzziness:

https://github.com/lampepfl/dotty/blob/a356581964813ad19b6f8380cac4344790ff5a72/compiler/src/dotty/tools/dotc/interactive/Completion.scala?rgh-link-date=2022-11-21T14%3A57%3A14Z#L452-L456

Can you share more info about why this was closed? Maybe it was a little bit premature 😅 thanks!

@rochala rochala mentioned this issue Mar 1, 2024
Merged
rochala added a commit that referenced this issue Apr 12, 2024
@rochala
Add custom matchers for completions (fuzzy search for presentation co…
acfc621 
…mpiler) (#19850)

Fixes scalameta/metals#4656
Fixes #5507
Fixes #17706

To ensure CI output will be the same on all runners, I'm scheduling runs
on all jvm versions + windows.

[test_windows_full]
[test_java8]
[test_java11]
[test_java15]
[test_java17]
[test_java18]
[test_java19]
olhotak pushed a commit to dotty-staging/dotty that referenced this issue Apr 15, 2024
@rochala @olhotak
Add custom matchers for completions (fuzzy search for presentation co…
f1060fa 
…mpiler) (scala#19850)

Fixes scalameta/metals#4656
Fixes scala#5507
Fixes scala#17706

To ensure CI output will be the same on all runners, I'm scheduling runs
on all jvm versions + windows.

[test_windows_full]
[test_java8]
[test_java11]
[test_java15]
[test_java17]
[test_java18]
[test_java19]
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
WojciechMazur added a commit that referenced this issue Jul 5, 2024
@WojciechMazur
Add custom matchers for completions (fuzzy search for presentation co…
953b7a7 
…mpiler) (#19850)

Fixes scalameta/metals#4656
Fixes #5507
Fixes #17706

To ensure CI output will be the same on all runners, I'm scheduling runs
on all jvm versions + windows.

[test_windows_full]
[test_java8]
[test_java11]
[test_java15]
[test_java17]
[test_java18]
[test_java19]
[Cherry-picked acfc621][modified]
WojciechMazur added a commit that referenced this issue Jul 5, 2024
@WojciechMazur
Add custom matchers for completions (fuzzy search for presentation co…
4fdde6b 
…mpiler) (#19850)

Fixes scalameta/metals#4656
Fixes #5507
Fixes #17706

To ensure CI output will be the same on all runners, I'm scheduling runs
on all jvm versions + windows.

[test_windows_full]
[test_java8]
[test_java11]
[test_java15]
[test_java17]
[test_java18]
[test_java19]
[Cherry-picked acfc621][modified]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:ide itype:enhancement
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Add custom matchers for completions (fuzzy search for presentation compiler) rochala/dotty
4 participants
@kubukoz @Duhemm @abgruszecki @Kordyjan