Skip to content

Unused special case for AnnotatedType in RefinedPrinter #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gsps opened this issue Jun 14, 2018 · 1 comment
Closed

Unused special case for AnnotatedType in RefinedPrinter #4657

gsps opened this issue Jun 14, 2018 · 1 comment

Comments

@gsps
Copy link
Contributor

gsps commented Jun 14, 2018

Looking through RefinedPrinter https://github.com/lampepfl/dotty/blob/76b110b5bb029a6607f517304dd2fa9c58547a88/compiler/src/dotty/tools/dotc/printing/RefinedPrinter.scala#L204 I noticed a case that ostensibly overrides the printing of AnnotatedType when testing the pickler (homogenizedView). In reality, that case just computes withoutPos(super.toText(tp)) without returning it and eventually falls through to super.toText(tp). Considering that pickling tests do work, it seems that the special case is not needed anymore, so I suggest we remove it.
@nicolasstucki
Copy link
Contributor

Should test this after #5713 is merged.

anatoliykmetyuk added a commit that referenced this issue Nov 13, 2019
@anatoliykmetyuk
Merge pull request #7548 from dotty-staging/fix-#4657
87ea7a6 
Fix #4657: Remove special case that is not needed anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsps @nicolasstucki