Skip to content

Crash when running npm run test #4109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jendrikw opened this issue Mar 12, 2018 · 5 comments
Closed

Crash when running npm run test #4109

jendrikw opened this issue Mar 12, 2018 · 5 comments

Comments

@jendrikw
Copy link

I was trying to do a PR for vscode-dotty, but I cannot run the tests.

Note that /home/jendrik/dev/scala/dotty is the folder which contains this repo.

$ cd vscode-dotty && npm run test

> [email protected] test /home/jendrik/dev/scala/dotty/vscode-dotty
> node ./node_modules/vscode/bin/test

### VS Code Extension Test Run ###
Current working directory: /home/jendrik/dev/scala/dotty/vscode-dotty
Running extension tests: /home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/code /home/jendrik/dev/scala/dotty/vscode-dotty/test --extensionDevelopmentPath=/home/jendrik/dev/scala/dotty/vscode-dotty --extensionTestsPath=/home/jendrik/dev/scala/dotty/vscode-dotty/test
[main 23:30:34] update#setState idle

bash: cannot set terminal process group (-1): Inappropriate ioctl for device
bash: no job control in this shell

[main 23:31:04] update#setState checking for updates

Error: Error: Cannot find module '/home/jendrik/dev/scala/dotty/vscode-dotty/test'
	at t.handleExtensionTests (/home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/resources/app/out/vs/workbench/node/extensionHostProcess.js:716:507)
	at /home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/resources/app/out/vs/workbench/node/extensionHostProcess.js:712:854
	at Object.g [as _notify] (/home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/resources/app/out/vs/workbench/node/extensionHostProcess.js:69:202)
	at Object.enter (/home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/resources/app/out/vs/workbench/node/extensionHostProcess.js:72:556)
	at n.Class.derive._oncancel._run (/home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/resources/app/out/vs/workbench/node/extensionHostProcess.js:74:380)
	at n.Class.derive._oncancel._completed (/home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/resources/app/out/vs/workbench/node/extensionHostProcess.js:73:823)
	at c (/home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/resources/app/out/vs/workbench/node/extensionHostProcess.js:77:267)
	at q.then.o.(anonymous function) (/home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/resources/app/out/vs/workbench/node/extensionHostProcess.js:77:481)
	at Object.g [as _notify] (/home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/resources/app/out/vs/workbench/node/extensionHostProcess.js:69:202)
	at Object.enter (/home/jendrik/dev/scala/dotty/vscode-dotty/.vscode-test/VSCode-linux-x64/resources/app/out/vs/workbench/node/extensionHostProcess.js:72:556)

[main 23:31:07] update#setState idle

Tests exited with code: 1
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test: `node ./node_modules/vscode/bin/test`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jendrik/.cache/npm/_logs/2018-03-12T22_31_10_662Z-debug.log
@smarter
Copy link
Member

smarter commented Mar 12, 2018

There's no tests for vscode-dotty currently, that's why this command fails.

@smarter smarter closed this as completed Mar 12, 2018
@jendrikw
Copy link
Author

Should the script in vscode-dotty be removed then? Can I do a PR?

@smarter
Copy link
Member

smarter commented Mar 12, 2018

I think it makes sense to keep it in case we add tests at some point.

@smarter
Copy link
Member

smarter commented Mar 12, 2018

Of course it'd be nicer to not have it crash, maybe by adding a dummy test.

@jendrikw
Copy link
Author

I don't have experience in writing vs code plugins, but I will try to write one.

smarter added a commit that referenced this issue Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants