Skip to content

IDE completion should know about renaming imports. #3979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odersky opened this issue Feb 11, 2018 · 1 comment
Closed

IDE completion should know about renaming imports. #3979

odersky opened this issue Feb 11, 2018 · 1 comment
Labels
area:ide stat:fix available

Comments

@odersky
Copy link
Contributor

odersky commented Feb 11, 2018

Say you have

import java.util.{List => JList}

Then scope completion with J should give JList. Right now it cannot to that because we return lists of symbols from completion requests, and List is clearly not a valid completion.

For the moment, renamed imports are simply ignored. To fix this, it would be good to first have some tests for completion requests.
Duhemm added a commit to dotty-staging/dotty that referenced this issue Aug 21, 2018
@Duhemm
Fix scala#3979: Completion for renamed imports
0975d2c 
We introduce a new `RenameAwareScope` that tracks the name associated
with a symbol in the scope. Calling `toListWithNames` returns the list
of symbols in this scope along with the name that should be used to
refer to the symbol in this scope.

Fixes scala#3979
@Duhemm Duhemm mentioned this issue Aug 21, 2018
Merged
Duhemm added a commit to dotty-staging/dotty that referenced this issue Sep 4, 2018
@Duhemm
Fix scala#3979: Completion for renamed imports
b46bcd8 
We introduce a new `RenameAwareScope` that tracks the name associated
with a symbol in the scope. Calling `toListWithNames` returns the list
of symbols in this scope along with the name that should be used to
refer to the symbol in this scope.

Fixes scala#3979
Duhemm added a commit to dotty-staging/dotty that referenced this issue Nov 1, 2018
@Duhemm
Fix scala#3979: Completion for renamed imports
7c77293 
We introduce a new `RenameAwareScope` that tracks the name associated
with a symbol in the scope. Calling `toListWithNames` returns the list
of symbols in this scope along with the name that should be used to
refer to the symbol in this scope.

Fixes scala#3979
@Duhemm
Copy link
Contributor

Duhemm commented Nov 18, 2018

There's a fix for that in #4977

Duhemm added a commit to dotty-staging/dotty that referenced this issue Nov 19, 2018
@Duhemm
Fix scala#3979: Completion for renamed imports
e33c635 
We introduce a new `RenameAwareScope` that tracks the name associated
with a symbol in the scope. Calling `toListWithNames` returns the list
of symbols in this scope along with the name that should be used to
refer to the symbol in this scope.

Fixes scala#3979
@Duhemm Duhemm mentioned this issue Nov 22, 2018
Merged
Duhemm added a commit to dotty-staging/dotty that referenced this issue Nov 27, 2018
@Duhemm
Fix scala#3979: Completion for renamed imports
ea8afdf 
We introduce a new `RenameAwareScope` that tracks the name associated
with a symbol in the scope. Calling `toListWithNames` returns the list
of symbols in this scope along with the name that should be used to
refer to the symbol in this scope.

Fixes scala#3979
Duhemm added a commit to dotty-staging/dotty that referenced this issue Nov 28, 2018
@Duhemm
Fix scala#3979: Completion for renamed imports
a073f97 
We introduce a new `RenameAwareScope` that tracks the name associated
with a symbol in the scope. Calling `toListWithNames` returns the list
of symbols in this scope along with the name that should be used to
refer to the symbol in this scope.

Fixes scala#3979
Duhemm added a commit to dotty-staging/dotty that referenced this issue Nov 30, 2018
@Duhemm
Fix scala#3979: Completion for renamed imports
317f16c 
We introduce a new `RenameAwareScope` that tracks the name associated
with a symbol in the scope. Calling `toListWithNames` returns the list
of symbols in this scope along with the name that should be used to
refer to the symbol in this scope.

Fixes scala#3979
Duhemm added a commit that referenced this issue Dec 2, 2018
@Duhemm
Merge pull request #4977 from dotty-staging/fix/3979
7c7af27 
Fix #3979: Completion for renamed imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:ide stat:fix available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odersky @Duhemm