Skip to content

Unpickling error #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OlivierBlanvillain opened this issue Jan 19, 2018 · 0 comments
Closed

Unpickling error #3873

OlivierBlanvillain opened this issue Jan 19, 2018 · 0 comments
Labels
stat:fix available

Comments

@OlivierBlanvillain
Copy link
Contributor

OlivierBlanvillain commented Jan 19, 2018 •
edited by smarter
Loading

This example fails to unpickle:

object Test {
  inline def sum2(ys: List[Int]): Unit = {
    ys.foldLeft(1)
  }
  val h1: ((List[Int]) => Unit) = sum2
}
smarter added a commit to dotty-staging/dotty that referenced this issue Jan 19, 2018
@smarter
Fix scala#3873: Properly unpickle shared TypeTrees
41cbd36 
When a TypeTree is represented by a SHAREDterm, we need to follow the
SHAREDterm and call `readTpt()` again. We cannot rely on `readTerm()`
following the SHAREDterm for us because a TypeTree can be pickled as
just a type.
smarter added a commit to dotty-staging/dotty that referenced this issue Jan 19, 2018
@smarter
Fix scala#3873: Properly unpickle shared TypeTrees
fbbb7c2 
When a TypeTree is represented by a SHAREDterm, we need to follow the
SHAREDterm and call `readTpt()` again. We cannot rely on `readTerm()`
following the SHAREDterm for us because a TypeTree can be pickled as
just a type.
odersky added a commit that referenced this issue Jan 21, 2018
@odersky
Merge pull request #3874 from dotty-staging/fix-shared-tpt-again
c2e5011 
Fix #3873: Properly unpickle shared TypeTrees
liufengyun pushed a commit to dotty-staging/dotty that referenced this issue Jan 23, 2018
@smarter @liufengyun
Fix scala#3873: Properly unpickle shared TypeTrees
ac07688 
When a TypeTree is represented by a SHAREDterm, we need to follow the
SHAREDterm and call `readTpt()` again. We cannot rely on `readTerm()`
following the SHAREDterm for us because a TypeTree can be pickled as
just a type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stat:fix available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smarter @OlivierBlanvillain