Skip to content

Remove magic in exhaustivity check #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liufengyun opened this issue Aug 24, 2017 · 0 comments
Closed

Remove magic in exhaustivity check #3015

liufengyun opened this issue Aug 24, 2017 · 0 comments
Assignees
@liufengyun
Labels
area:pattern-matching itype:enhancement

Comments

@liufengyun
Copy link
Contributor

liufengyun commented Aug 24, 2017 •
edited
Loading

In the exhaustivity check, when decomposing a type path.B[Int, String], we get two child classes C1 and C1. The problem is how to turn the two classes into proper types related to path, Int and String?

Current implementation resorts to some ad-hoc hack which is not well-grounded. The correct way to solve the problem is to use type inference, as suggested by Martin.
@liufengyun liufengyun self-assigned this Aug 24, 2017
liufengyun added a commit to dotty-staging/dotty that referenced this issue Aug 25, 2017
@liufengyun
initial work on scala#3015
9db223e
liufengyun added a commit to dotty-staging/dotty that referenced this issue Sep 4, 2017
@liufengyun
fix scala#3015: use type inference to type child classes
a3f7904
liufengyun added a commit to dotty-staging/dotty that referenced this issue Sep 4, 2017
@liufengyun
fix scala#3015: use type inference to type child classes
6f919cd
@liufengyun liufengyun mentioned this issue Sep 4, 2017
Closed
liufengyun added a commit to dotty-staging/dotty that referenced this issue Sep 5, 2017
@liufengyun
fix scala#3015: use type inference to type child classes
cb5807c
@liufengyun liufengyun mentioned this issue Sep 6, 2017
Closed
liufengyun added a commit to dotty-staging/dotty that referenced this issue Sep 6, 2017
@liufengyun
fix scala#3015: use type inference to type child classes
a16f299
liufengyun added a commit to dotty-staging/dotty that referenced this issue Sep 7, 2017
@liufengyun
fix scala#3015: use type inference to type child classes
6e50ab3
liufengyun added a commit to dotty-staging/dotty that referenced this issue Sep 8, 2017
@liufengyun
fix scala#3015: use type inference to type child classes
559e544
odersky pushed a commit to dotty-staging/dotty that referenced this issue Sep 14, 2017
@liufengyun @odersky
fix scala#3015: use type inference to type child classes
10405f3
odersky pushed a commit to dotty-staging/dotty that referenced this issue Sep 17, 2017
@liufengyun @odersky
fix scala#3015: use type inference to type child classes
9a26ec2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liufengyun liufengyun

Labels
area:pattern-matching itype:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liufengyun @nicolasstucki