Skip to content

Filenames should be escaped in test reproduction instructions #2490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue May 20, 2017 · 1 comment
Closed

Filenames should be escaped in test reproduction instructions #2490

smarter opened this issue May 20, 2017 · 1 comment
Labels
area:testing itype:bug prio:low

Comments

@smarter
Copy link
Member

smarter commented May 20, 2017

When a test fail, the logfile may contain a message like:

the test can be reproduced by running:
./bin/dotc ...
compiler/../library/src/scala/compat/java8/JFunction0$mcB$sp.java

The filename contains a $ that needs to be escaped to be able to run the given command in a shell
@smarter
Copy link
Member Author

smarter commented May 20, 2017

The simplest solution would be to put single quotes around each filename.

anatoliykmetyuk added a commit that referenced this issue Jan 9, 2020
@anatoliykmetyuk
Merge pull request #7937 from dotty-staging/fix-#2490
061dc96 
Fix #2490: Put single quotes around each filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:testing itype:bug prio:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smarter