Skip to content

Test logs sometimes contain color codes #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue Apr 12, 2017 · 2 comments
Closed

Test logs sometimes contain color codes #2245

smarter opened this issue Apr 12, 2017 · 2 comments
Assignees
@felixmulder

Comments

@smarter
Copy link
Member

smarter commented Apr 12, 2017

This doesn't happen with all tests, but I've seen it happen with "dotty1$1".
@felixmulder
Copy link
Contributor

I can't reproduce this - can you do this post #2248?

@smarter
Copy link
Member Author

smarter commented Apr 13, 2017

You can reproduce it by running tastyBootstrap, if you look at the options passed to tastyBootstrap#dotty1 you'll see that they don't include the option to disable colors.

smarter added a commit that referenced this issue Apr 13, 2017
@smarter
Merge pull request #2259 from dotty-staging/fix-#2245
889ed89 
Fix #2245: strip colors from strings before writing to file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixmulder felixmulder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smarter @felixmulder