Skip to content

Enum completions in new context should be filtered #19968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rochala opened this issue Mar 18, 2024 · 2 comments · Fixed by #20304
Closed

Enum completions in new context should be filtered #19968

rochala opened this issue Mar 18, 2024 · 2 comments · Fixed by #20304
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools good first issue Perfect for someone who wants to get started contributing itype:enhancement Spree Suitable for a future Spree
Milestone
3.5.0

Comments

@rochala
Copy link
Contributor

rochala commented Mar 18, 2024

Compiler version

3.4.1

Minimized code

enum NewEnum:
  case Left, Right

new NewEn@@
new NewEnum.Le@@

Output

Both completions requests suggest NewEnum and allow us to compile it even if they are illegal and will result in error.

Expectation

These completions should be hidden as they are illegal in this context.
@rochala rochala added itype:enhancement good first issue Perfect for someone who wants to get started contributing Spree Suitable for a future Spree area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels Mar 18, 2024
@mbovel
Copy link
Member

mbovel commented Apr 26, 2024

This issue was picked for the Scala Issue Spree of April 30th. @mbovel and @aherlihy will be working on it. If you have any insight into the issue or guidance on how to fix it, please leave it here.

@mbovel
Copy link
Member

mbovel commented Apr 29, 2024

Spree team update: @rochala and @aherlihy will work on this tomorrow, via Zoom.

@rochala rochala mentioned this issue Apr 30, 2024
Merged
rochala added a commit that referenced this issue May 6, 2024
@rochala
Don't show enum completions in new keyword context (#20304)
c5f2064 
Fixes #19968
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this issue May 6, 2024
@rochala @WojciechMazur
Don't show enum completions in new keyword context (scala#20304)
74f4a5a 
Fixes scala#19968
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
WojciechMazur pushed a commit that referenced this issue Jul 6, 2024
@rochala @WojciechMazur
Don't show enum completions in new keyword context (#20304)
ff5bc2f 
Fixes #19968
[Cherry-picked c5f2064]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools good first issue Perfect for someone who wants to get started contributing itype:enhancement Spree Suitable for a future Spree
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Don't show enum completions in new keyword context rochala/dotty
3 participants
@mbovel @Kordyjan @rochala