Skip to content

Re-merge binary literals #19695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kordyjan opened this issue Feb 14, 2024 · 9 comments · Fixed by #20246
Closed

Re-merge binary literals #19695

Kordyjan opened this issue Feb 14, 2024 · 9 comments · Fixed by #20246
Assignees
Labels
needs-minor-release This PR cannot be merged until the next minor release
Milestone

Comments

@Kordyjan
Copy link
Contributor

Kordyjan commented Feb 14, 2024

Binary literals PR should be re-merged in time for 3.5 release.

#19405

@odersky
Copy link
Contributor

odersky commented Feb 14, 2024

Why? I though they need a minor release?

@SethTisue
Copy link
Member

"before 3.5" is a bit ambiguous — presumably "in time for 3.5" was meant here.

@nicolasstucki
Copy link
Contributor

I updated the milestone in #19405 to 3.5 to avoid confusion.

@odersky
Copy link
Contributor

odersky commented Feb 15, 2024

Ah indeed I misunderstood. So with the milestone added, can we close this issue now?

@Sporarum
Copy link
Contributor

Thinking more about it, shouldn't they be added as experimental first, validated by the SIP comittee, and only then merged as non-experimental ?

(I think it is fine to do an exception for this case, but it is good to be aware that this is what we are doing)

@Kordyjan
Copy link
Contributor Author

That should be the procedure, but as far as I remember, there are problems with experimental switches during parsing.

@odersky
Copy link
Contributor

odersky commented Feb 15, 2024

Not for language imports. We do honor them during parsing. But in this case, since the SIP is already accepted, we don't need to go though the procedure again.

@Sporarum
Copy link
Contributor

Out of curiosity, do we honor them as well during tokenization ?

(That is where the parsing of integer literals is done)

@Kordyjan Kordyjan added the needs-minor-release This PR cannot be merged until the next minor release label Mar 26, 2024
@Gedochao
Copy link
Contributor

Gedochao commented Apr 3, 2024

It has been decided to be included in the 3.5.0 release.

sjrd added a commit that referenced this issue Apr 22, 2024
Closes #19695

Cherry-picked without changes from reverted PR #19405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-minor-release This PR cannot be merged until the next minor release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants