Skip to content

Another ClassNotFoundException when evaluating inline def which calls a macro defined in a super-class #18434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
smarter opened this issue Aug 21, 2023 · 0 comments
Open

Another ClassNotFoundException when evaluating inline def which calls a macro defined in a super-class #18434

smarter opened this issue Aug 21, 2023 · 0 comments
Assignees
@nicolasstucki
Labels
area:metaprogramming:quotes Issues related to quotes and splices itype:bug

Comments

@smarter
Copy link
Member

smarter commented Aug 21, 2023

Issue #18393 can still be reproduced if the macro call ${ this.impl() } is replaced by ${ impl() }:

  1. Perform this change in tests/pos-macros/i18393/Inline_2.scala
  2. Run scala3-compiler-bootstrapped/testCompilation tests/pos-macros/i18393 and observe an error.
@smarter smarter added itype:bug area:metaprogramming:quotes Issues related to quotes and splices labels Aug 21, 2023
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Aug 24, 2023
@nicolasstucki
Fix macro dependency tracking for this
e14979d 
The symbols of trees do not have enough information to determine the
full dependencies. For example, if we have an `Ident` we need to look at
its type to figure out which is the `this` prefix on which it is defined.

Fix scala#18434
@nicolasstucki nicolasstucki mentioned this issue Aug 24, 2023
Closed
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Feb 7, 2024
@nicolasstucki
Fix macro dependency tracking for this
71f9a9f 
The symbols of trees do not have enough information to determine the
full dependencies. For example, if we have an `Ident` we need to look at
its type to figure out which is the `this` prefix on which it is defined.

Fix scala#18434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasstucki nicolasstucki

Labels
area:metaprogramming:quotes Issues related to quotes and splices itype:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix macro dependency tracking for this dotty-staging/dotty
2 participants
@smarter @nicolasstucki