Skip to content

Refuse trailing whitespace in build #17196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odersky opened this issue Apr 1, 2023 · 1 comment
Open

Refuse trailing whitespace in build #17196

odersky opened this issue Apr 1, 2023 · 1 comment

Comments

@odersky
Copy link
Contributor

odersky commented Apr 1, 2023

I see increasing occurrences of trailing whitespaces in the dotty code base. This should be avoided since it messes up histories and diffs.

  1. Everyone: Please configure your editor so that trailing whitespace are stripped on save
  2. We should have a PR check that refuses to merge a PR if there is trailing whitespace

We used to have that at some point, but it seems it's no longer active.

@odersky odersky added stat:needs triage Every issue needs to have an "area" and "itype" label area:infrastructure and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Apr 1, 2023
@soronpo
Copy link
Contributor

soronpo commented Apr 3, 2023

I think the dotty repo should have a .scalafmt config and enforce it as a whole. I imagine it may be a drastic diff since the codebase is currently very inconsistent.

nicolasstucki added a commit that referenced this issue Apr 4, 2023
Cleanup for the issue stated in #17196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants