-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Scaladoc: add tests for extension
signatures
#17108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello, I would like to work on this issue. From what I understand the SignatureTest.scala file, it is linked to the TranslatableSignaturesTestCases.scala file which allows to call different scala files such as extensionParams.scala which contains examples of extension methods to test. So, is it enough to add new examples in this file (or another one), or do we need to modify the SignatureTest.scala file? |
@Dedelweiss I think that SignatureTest.scala will have to be modified to add checking for |
In this PR, I added new tests examples for extensions's signatures. To do that I did multiple changement : ### SignatureTest - Added Extension for expected and actual signatures - There needs to be a unique name for each signature, but extensions don't have one like defs. So for now I have the signature itself as a title (can change if better idea) - Added "extensions" for member to test ### ExtensionParam - I changed the extensions so that they are all unique and test different cases. ### TranslatableSignaturesTestCases - Added a filterNot for ExtensionMethodSignature class. Too many duplicate extensions, it creates an error and I think it's not mandatory to test the extensions on this file too. Fixes: #17108
Scaladoc should test signatures of
extension
s just like it's done fordef
s. This way we can prevent issues like #16647The appropriate file for this is most likely:
https://github.com/lampepfl/dotty/blob/main/scaladoc/test/dotty/tools/scaladoc/signatures/SignatureTest.scala
The text was updated successfully, but these errors were encountered: