Skip to content

Compiler crash when overriding Java var-arg constructor #17066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kavedaa opened this issue Mar 7, 2023 · 2 comments · Fixed by #17096
Closed

Compiler crash when overriding Java var-arg constructor #17066

kavedaa opened this issue Mar 7, 2023 · 2 comments · Fixed by #17096
Assignees
Labels
compat:java itype:bug itype:crash regression This worked in a previous version but doesn't anymore
Milestone

Comments

@kavedaa
Copy link

kavedaa commented Mar 7, 2023

Compiler version

3.2.2, 3.3.0-RC1

Minimized code

Java:

public class Foo {
  public Foo(String... xs) { }
}

Scala:

class Bar extends Foo {
  def this(xs: String*) = this()
}

Output (click arrow to expand)

[info] compiling 1 Scala source and 1 Java source to E:\prog\jvm\scala\bugs\java-varargs\target\scala-3.2.2\classes ...
java.lang.AssertionError: assertion failed: constructor Bar in class Bar while running MegaPhase{crossVersionChecks, protectedAccessors, extmethods, uncacheGivenAliases, elimByName, hoistSuperArgs, forwardDepChecks, specializeApplyMethods, tryCatchPatterns, patternMatcher} on E:\prog\jvm\scala\bugs\java-varargs\src\main\scala\Bar.scala
[info] exception occurred while compiling E:\prog\jvm\scala\bugs\java-varargs\src\main\scala\Bar.scala
java.lang.AssertionError: assertion failed: constructor Bar in class Bar while compiling E:\prog\jvm\scala\bugs\java-varargs\src\main\java\Foo.java, E:\prog\jvm\scala\bugs\java-varargs\src\main\scala\Bar.scala
[error] ## Exception when compiling 2 sources to E:\prog\jvm\scala\bugs\java-varargs\target\scala-3.2.2\classes
[error] java.lang.AssertionError: assertion failed: constructor Bar in class Bar
[error] scala.runtime.Scala3RunTime$.assertFailed(Scala3RunTime.scala:8)
[error] dotty.tools.dotc.transform.ForwardDepChecks.checkSelfConstructorCall(ForwardDepChecks.scala:117)
[error] dotty.tools.dotc.transform.ForwardDepChecks.transformApply(ForwardDepChecks.scala:123)
[error] dotty.tools.dotc.transform.ForwardDepChecks.transformApply(ForwardDepChecks.scala:120)
[error] dotty.tools.dotc.transform.MegaPhase.goApply(MegaPhase.scala:650)
@kavedaa kavedaa added itype:bug itype:crash stat:needs triage Every issue needs to have an "area" and "itype" label labels Mar 7, 2023
@nicolasstucki nicolasstucki added compat:java and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Mar 8, 2023
@prolativ
Copy link
Contributor

prolativ commented Mar 8, 2023

This used to work until 3.0.2 and then from 3.1.0 up to 3.1.2 this was a compilation error rather than a crash

@prolativ prolativ added the regression This worked in a previous version but doesn't anymore label Mar 8, 2023
@prolativ
Copy link
Contributor

prolativ commented Mar 8, 2023

The first breakage seems to be in 8130c32
However the compilation error in 3.1.0-3.1.2 is quite strange (or at least the position of the error doesn't seem to match the message):

[error] ./varargs/Bar.scala:1:7
[error] secondary constructor must call a preceding constructor
[error] class Bar extends Foo {
[error]       ^

@prolativ prolativ added this to the 3.3.1-RC1 milestone Mar 13, 2023
odersky added a commit to dotty-staging/dotty that referenced this issue Mar 13, 2023
odersky added a commit to dotty-staging/dotty that referenced this issue Mar 13, 2023
smarter added a commit that referenced this issue Mar 13, 2023
Dedelweiss pushed a commit to Dedelweiss/dotty that referenced this issue Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat:java itype:bug itype:crash regression This worked in a previous version but doesn't anymore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants