Skip to content

Doc website: <none> instead of dependent return type #16057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sporarum opened this issue Sep 16, 2022 · 0 comments · Fixed by #17213
Closed

Doc website: <none> instead of dependent return type #16057

Sporarum opened this issue Sep 16, 2022 · 0 comments · Fixed by #17213
Labels
area:doctool itype:bug
Milestone
3.4.0

Comments

@Sporarum
Copy link
Contributor

For example:
nightly:
https://dotty.epfl.ch/api/scala/Tuple$.html#fromProductTyped-96d
3.2.0:
https://scala-lang.org/api/3.x/scala/Tuple$.html#fromProductTyped-96d
@Sporarum Sporarum added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Sep 16, 2022
@TheElectronWill TheElectronWill added area:doctool and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Sep 17, 2022
@Florian3k Florian3k mentioned this issue Apr 6, 2023
Merged
Florian3k added a commit that referenced this issue Jun 2, 2023
@Florian3k
Scaladoc: type rendering fixes and improvements (#17213)
57c2b66 
This PR introduces multiple fixes and improvements to type rendering in
Scaladoc

- Fixed rendering of TypeRefs (`A#B`) and TermRefs (`a.b.type`)
- Fixed rendering of `Tuple1[T]` (previously `(T)`)
- Fixed rendering of `this.type` (except for type bounds, see below)
- Types with `@showAsInfix` are rendered infix
- Correct parenthesizing around infix types, `&` types, `|` types and
function types
- Type parameters of superclasses in inherited methods are substituted
with actual types from inheriting class/trait (see
`scaladoc-testcases/src/tests/supertypeParamsSubstitution.scala`)

https://github.com/lampepfl/dotty/pull/17213/files#diff-93a78912075a9fdb34fefa437d191be59888cb723ccb244374e77033d9eca779R12-R20
- `this` and `type` are highlighted as keywords

fixes #16024
fixes #16143
fixed #16057
fixes #16084 (partially) - fixed rendering of `Int` instead of `n.type`
and `(This, n.type)` instead of `Split[This, n.type]`. `this.type` in
type bounds remains unfixed. I created separate issue for that #17226

Documentation with those changes has been deployed to
https://scala3doc.virtuslab.com/pr-types-rendering-fixes/scala3/api/index.html
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:doctool itype:bug
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Scaladoc: type rendering fixes and improvements Florian3k/scala3
3 participants
@TheElectronWill @Kordyjan @Sporarum