Assertion failed: Attempt to commit TS[...] into already committed TS[...] #14907
Assignees
Labels
Comments
FlorianCassayre
added
itype:bug
itype:crash
stat:needs triage
odersky
removed
the
stat:needs triage
|
Can't reproduce on either 3.1.1 or 3.1.3-RC1-bin-20220410-220b753-NIGHTLY, did you minimize too much? |
|
I can reproduce on Scastie and GitHub Actions. See the Actions output: FlorianCassayre/dotty-i14907 |
|
Ah thanks, to reproduce when using the compiler directly requires adding the flag |
Good to know, thanks for the precisions, I'll keep that in mind for the next time. |
FlorianCassayre
added a commit
to FlorianCassayre/master-project
that referenced
this issue
Apr 13, 2022
smarter
added a commit
to dotty-staging/dotty
that referenced
this issue
Apr 26, 2022
If the added test case is run with `-Yforce-sbt-phases`, a LazyRef (created in the LazyRef case of TypeMap#mapOver) captures a Context. Later, that LazyRef is forced, but at that point the TyperState of the captured Context is already committed, so we're not allowed to commit anything in it anymore. But forcing the LazyRef ends up calling `isFullyDefined` which unconditionally creates a temporary TyperState and commit it, thus triggering the assertion. We fix this by relaxing the assertion to allow committing into a TyperState if there's nothing to commit. This should handle all LazyRefs since they never wrap uninstantiated type variables in practice. Fixes scala#14907.
|
With the latest nightly, I'm now getting a different assertion error (from a piece of code containing a similar snippet). I'll try to produce a minimization. |
bishabosha
pushed a commit
to dotty-staging/dotty
that referenced
this issue
Oct 18, 2022
If the added test case is run with `-Yforce-sbt-phases`, a LazyRef (created in the LazyRef case of TypeMap#mapOver) captures a Context. Later, that LazyRef is forced, but at that point the TyperState of the captured Context is already committed, so we're not allowed to commit anything in it anymore. But forcing the LazyRef ends up calling `isFullyDefined` which unconditionally creates a temporary TyperState and commit it, thus triggering the assertion. We fix this by relaxing the assertion to allow committing into a TyperState if there's nothing to commit. This should handle all LazyRefs since they never wrap uninstantiated type variables in practice. Fixes scala#14907.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Compiler version
3.1.3-RC1-bin-20220410-220b753-NIGHTLYdown to3.0.1using-Yforce-sbt-phasesMinimized code
Output (click arrow to expand)
The compiler outputs additional stuff to the standard output.
This code compiles on
3.0.0, but not on3.0.1and later.The text was updated successfully, but these errors were encountered: