Skip to content

Remove old DecompilerPrinter #14806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolasstucki opened this issue Mar 29, 2022 · 0 comments · Fixed by #15445
Closed

Remove old DecompilerPrinter #14806

nicolasstucki opened this issue Mar 29, 2022 · 0 comments · Fixed by #15445
Labels
exp:novice itype:enhancement Spree Suitable for a future Spree

Comments

@nicolasstucki
Copy link
Contributor

The old implementation for the decompiler dotty.tools.dotc.printing.DecompilerPrinter is not used by the decompiler anymore. It is only used by the ReplPrinter. We should remove DecompilerPrinter by merging it with ReplPrinter.
EstebanMarin added a commit to EstebanMarin/dotty that referenced this issue Jun 14, 2022
@EstebanMarin
Solves
0e42e68 
fixes scala#14806
EstebanMarin added a commit to EstebanMarin/dotty that referenced this issue Jun 14, 2022
@EstebanMarin
Remove DecompilerPrinter.scala
a8a16e8 
Description: We tested all methods in REPL and none of them are used
all test passes. Do while do not exist anymore, `packages`
are printed, not content of classes either.

fixes scala#14806
EstebanMarin added a commit to EstebanMarin/dotty that referenced this issue Jun 14, 2022
@EstebanMarin
Remove DecompilerPrinter.scala
28e81cc 
Description: We tested all methods in REPL and none of them are used
all test passes. Do while do not exist anymore, `packages`
are printed, not content of classes either.

fixes scala#14806
@EstebanMarin EstebanMarin mentioned this issue Jun 14, 2022
Merged
EstebanMarin added a commit to EstebanMarin/dotty that referenced this issue Jun 16, 2022
@EstebanMarin
Remove DecompilerPrinter.scala
5afdaaf 
Description: We tested all methods in REPL and none of them are used
all test passes. Do while do not exist anymore, `packages`
are printed, not content of classes either.

fixes scala#14806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp:novice itype:enhancement Spree Suitable for a future Spree
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove DecompilerPrinter.scala EstebanMarin/dotty
1 participant
@nicolasstucki