-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Unresolved symbol while pickling quote #13732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Workaround - inline def runEffectImpl[T: Type]: Expr[T] = ???
+ def runEffectImpl[T: Type]: Expr[T] = ??? |
@deniszo and I looked at this during today's spree. Some observations:
It seems that for some reason in this case, wants to pickle a quote whose body consists solely of |
Is it expected that this issue can be solved separately from / without #12540 (or a similar reworking of quote pickling)? |
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the `Splicer` phase and the result of the transformation can be `-Ycheck`ed. Now, the `PickleQuotes` phase only needs to extract the contents of the holes, pickle the quote and put them into a call to `unpickleExprV2`/`unpickleTypeV2`. We add `unpickleExprV2` to support some optimization in the encoding of the pickled quote. Namely we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changing `unpickleExpr` the current compiler will be able to handle the old encoding in binaries compiled with older compilers. The `unpickleTypeV2` is just a version of `unpickleType` that does not take the `termHole` parameter which is always `null`. With `-Yscala-relese` 3.0 or 3.1, the compiler will generate calls to the old `unpickleExpr`/`unpickleType`. Fixes scala#8100 Fixes scala#12440 Fixes scala#13563 Fixes scala#14337 Fixes scala#14373 Closes scala#13732
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the `Splicer` phase and the result of the transformation can be `-Ycheck`ed. Now, the `PickleQuotes` phase only needs to extract the contents of the holes, pickle the quote and put them into a call to `unpickleExprV2`/`unpickleTypeV2`. We add `unpickleExprV2` to support some optimization in the encoding of the pickled quote. Namely we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changing `unpickleExpr` the current compiler will be able to handle the old encoding in binaries compiled with older compilers. The `unpickleTypeV2` is just a version of `unpickleType` that does not take the `termHole` parameter which is always `null`. With `-Yscala-relese` 3.0 or 3.1, the compiler will generate calls to the old `unpickleExpr`/`unpickleType`. Fixes scala#8100 Fixes scala#12440 Fixes scala#13563 Fixes scala#14337 Fixes scala#14373 Closes scala#13732
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the `Splicer` phase and the result of the transformation can be `-Ycheck`ed. Now, the `PickleQuotes` phase only needs to extract the contents of the holes, pickle the quote and put them into a call to `unpickleExprV2`/`unpickleTypeV2`. We add `unpickleExprV2` to support some optimization in the encoding of the pickled quote. Namely we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changing `unpickleExpr` the current compiler will be able to handle the old encoding in binaries compiled with older compilers. The `unpickleTypeV2` is just a version of `unpickleType` that does not take the `termHole` parameter which is always `null`. With `-Yscala-relese` 3.0 or 3.1, the compiler will generate calls to the old `unpickleExpr`/`unpickleType`. Fixes scala#8100 Fixes scala#12440 Fixes scala#13563 Fixes scala#14337 Fixes scala#14373 Closes scala#13732
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the `Splicer` phase and the result of the transformation can be `-Ycheck`ed. Now, the `PickleQuotes` phase only needs to extract the contents of the holes, pickle the quote and put them into a call to `unpickleExprV2`/`unpickleTypeV2`. We add `unpickleExprV2` to support some optimization in the encoding of the pickled quote. Namely we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changing `unpickleExpr` the current compiler will be able to handle the old encoding in binaries compiled with older compilers. The `unpickleTypeV2` is just a version of `unpickleType` that does not take the `termHole` parameter which is always `null`. With `-Yscala-relese` 3.0 or 3.1, the compiler will generate calls to the old `unpickleExpr`/`unpickleType`. Fixes scala#8100 Fixes scala#12440 Fixes scala#13563 Fixes scala#14337 Fixes scala#14373 Closes scala#13732
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the `Splicer` phase and the result of the transformation can be `-Ycheck`ed. Now, the `PickleQuotes` phase only needs to extract the contents of the holes, pickle the quote and put them into a call to `unpickleExprV2`/`unpickleTypeV2`. We add `unpickleExprV2` to support some optimization in the encoding of the pickled quote. Namely we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changing `unpickleExpr` the current compiler will be able to handle the old encoding in binaries compiled with older compilers. The `unpickleTypeV2` is just a version of `unpickleType` that does not take the `termHole` parameter which is always `null`. With `-Yscala-relese` 3.0 or 3.1, the compiler will generate calls to the old `unpickleExpr`/`unpickleType`. Fixes scala#8100 Fixes scala#12440 Fixes scala#13563 Fixes scala#14337 Fixes scala#14373 Closes scala#13732
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the `Splicer` phase and the result of the transformation can be `-Ycheck`ed. Now, the `PickleQuotes` phase only needs to extract the contents of the holes, pickle the quote and put them into a call to `unpickleExprV2`/`unpickleTypeV2`. We add `unpickleExprV2` to support some optimization in the encoding of the pickled quote. Namely we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changing `unpickleExpr` the current compiler will be able to handle the old encoding in binaries compiled with older compilers. The `unpickleTypeV2` is just a version of `unpickleType` that does not take the `termHole` parameter which is always `null`. With `-Yscala-relese` 3.0 or 3.1, the compiler will generate calls to the old `unpickleExpr`/`unpickleType`. Fixes scala#8100 Fixes scala#12440 Fixes scala#13563 Fixes scala#14337 Fixes scala#14373 Closes scala#13732
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the `Splicer` phase and the result of the transformation can be `-Ycheck`ed. Now, the `PickleQuotes` phase only needs to extract the contents of the holes, pickle the quote and put them into a call to `unpickleExprV2`/`unpickleTypeV2`. We add `unpickleExprV2` to support some optimization in the encoding of the pickled quote. Namely we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changing `unpickleExpr` the current compiler will be able to handle the old encoding in binaries compiled with older compilers. The `unpickleTypeV2` is just a version of `unpickleType` that does not take the `termHole` parameter which is always `null`. With `-Yscala-relese` 3.0 or 3.1, the compiler will generate calls to the old `unpickleExpr`/`unpickleType`. Fixes scala#8100 Fixes scala#12440 Fixes scala#13563 Fixes scala#14337 Fixes scala#14373 Closes scala#13732
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the `Splicer` phase and the result of the transformation can be `-Ycheck`ed. Now, the `PickleQuotes` phase only needs to extract the contents of the holes, pickle the quote and put them into a call to `unpickleExprV2`/`unpickleTypeV2`. We add `unpickleExprV2` to support some optimization in the encoding of the pickled quote. Namely we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changing `unpickleExpr` the current compiler will be able to handle the old encoding in binaries compiled with older compilers. The `unpickleTypeV2` is just a version of `unpickleType` that does not take the `termHole` parameter which is always `null`. With `-Yscala-relese` 3.0 or 3.1, the compiler will generate calls to the old `unpickleExpr`/`unpickleType`. Fixes scala#8100 Fixes scala#12440 Fixes scala#13563 Fixes scala#14337 Fixes scala#14373 Closes scala#13732
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the `Splicer` phase and the result of the transformation can be `-Ycheck`ed. Now, the `PickleQuotes` phase only needs to extract the contents of the holes, pickle the quote and put them into a call to `unpickleExprV2`/`unpickleTypeV2`. We add `unpickleExprV2` to support some optimization in the encoding of the pickled quote. Namely we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changing `unpickleExpr` the current compiler will be able to handle the old encoding in binaries compiled with older compilers. The `unpickleTypeV2` is just a version of `unpickleType` that does not take the `termHole` parameter which is always `null`. With `-Yscala-relese` 3.0 or 3.1, the compiler will generate calls to the old `unpickleExpr`/`unpickleType`. Fixes scala#8100 Fixes scala#12440 Fixes scala#13563 Fixes scala#14337 Fixes scala#14373 Closes scala#13732
Compiler version
3.1.0
Minimized code
Related to #13563
Output
Expectation
Should compile
The text was updated successfully, but these errors were encountered: