Skip to content

Nightly Dotty workflow of 2021-04-11 failed #12046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions bot opened this issue Apr 11, 2021 · 3 comments · Fixed by #12074
Closed

Nightly Dotty workflow of 2021-04-11 failed #12046

github-actions bot opened this issue Apr 11, 2021 · 3 comments · Fixed by #12074
Assignees
@griggt
Labels
area:infrastructure itype:bug

Comments

@github-actions
Copy link
Contributor

See https://github.com/lampepfl/dotty/actions/runs/737284988
@smarter
Copy link
Member

smarter commented Apr 12, 2021

Hmm we still have the issue that publish_nightly fails if there's been no new commit since the previous nightly, so we should either filter that out or finally fix the root cause, what do you think @griggt ?

@smarter
Copy link
Member

smarter commented Apr 12, 2021

As a short term fix I suggest replacing nightly_documentation in https://github.com/lampepfl/dotty/blob/85a03eebe0fc4b11e0f7f8c1f121cc583b0927de/.github/workflows/ci.yaml#L677 by the dependencies of publish_nightly.

@griggt griggt mentioned this issue Apr 13, 2021
Merged
@griggt
Copy link
Contributor

griggt commented Apr 13, 2021

I think we should fix the workflow to skip publishing if there are no new commits: #12074

@griggt griggt self-assigned this Apr 13, 2021
smarter added a commit that referenced this issue Apr 16, 2021
@smarter
Merge pull request #12074 from griggt/fix-#12046
090b1b1 
Fix #12046: skip publishing nightly build when no new commits since last publish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griggt griggt

Labels
area:infrastructure itype:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #12046: skip publishing nightly build when no new commits since last publish griggt/dotty
2 participants
@smarter @griggt