Skip to content

Implement support for negDir #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DarkDimius opened this issue Feb 19, 2016 · 1 comment
Closed

Implement support for negDir #1110

DarkDimius opened this issue Feb 19, 2016 · 1 comment
Assignees
@VladimirNik
Labels
area:infrastructure

Comments

@DarkDimius
Copy link
Contributor

Neg tests at the moment take expected number of errors as an argument. Since #1106 we can optionally mark lines where errors are expected.

I propose we change all negtests to require marked lines.
This would allow to have a neg-dir instead of test-per-neg-test. This in turn would allow to simply drop a file there and will reduce number of merge conflicts.
@odersky
Copy link
Contributor

odersky commented Feb 19, 2016

+1

@VladimirNik VladimirNik self-assigned this Feb 22, 2016
@VladimirNik VladimirNik mentioned this issue Feb 22, 2016
Merged
odersky added a commit that referenced this issue Mar 3, 2016
@odersky
Merge pull request #1122 from dotty-staging/neg-lines-2
6f82c22 
Neg tests: remove xerror parameter from neg tests (#1110)
@odersky odersky closed this as completed Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VladimirNik VladimirNik

Labels
area:infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@odersky @DarkDimius @VladimirNik