Skip to content

JavaParser is skipping some annotations that ClassfileParser is picking up #10788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kordyjan opened this issue Dec 14, 2020 · 2 comments · Fixed by #11117
Closed

JavaParser is skipping some annotations that ClassfileParser is picking up #10788

Kordyjan opened this issue Dec 14, 2020 · 2 comments · Fixed by #11117
Assignees
@Kordyjan
Labels
compat:java compat:scala2 itype:bug
Milestone
3.0.0

Comments

@Kordyjan
Copy link
Contributor

I've encountered this behavior while I was testing #10751. When Test_1.scala name is changed to Test_0.scala here, the test started failing. It seems to be caused by JavaParser is skipping some annotations.
@Kordyjan Kordyjan self-assigned this Dec 14, 2020
@noti0na1
Copy link
Member

Currently, the JavaParser in dotty only parses annotations without arguments. Maybe we need to port this part from scalac.

@Kordyjan
Copy link
Contributor Author

Kordyjan commented Dec 15, 2020 •
edited
Loading

Maybe we need to port this part from scalac.

That is my current plan.

@Kordyjan Kordyjan linked a pull request Jan 18, 2021 that will close this issue
Support for parsing annotation arguments from java #11117
Merged
michelou pushed a commit to michelou/scala3 that referenced this issue Feb 5, 2021
@Kordyjan @michelou
Fix scala#10788: Parsing arguments for java annotations
f7a0667 
* A port of fixes from scala/scala#8781 with improvements.
* Some of improvements come from scala/scala#8982.
* There are small changes to typer to allow for single elements of any
  type T be used where array of T is expected inside of java annotations
  arguments as it is correct in java and is used in 2 files in scala
  standard library.
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kordyjan Kordyjan

Labels
compat:java compat:scala2 itype:bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Support for parsing annotation arguments from java
2 participants
@noti0na1 @Kordyjan