Skip to content

Doc sources contain spaces at end of lines #10138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
odersky opened this issue Nov 1, 2020 · 1 comment
Closed

Doc sources contain spaces at end of lines #10138

odersky opened this issue Nov 1, 2020 · 1 comment
Assignees

Comments

@odersky
Copy link
Contributor

odersky commented Nov 1, 2020

We have a general policy of stripping all spaces at end of lines on save, since that keeps diffs small. Currently scala3doc sources violate this requirement.

@odersky odersky changed the title Doc sources spaces spaces at end of lines Doc sources contain spaces at end of lines Nov 1, 2020
@abgruszecki abgruszecki self-assigned this Nov 2, 2020
@abgruszecki
Copy link
Contributor

We should also make the indentation in doc sources uniform. Right now we have a good opportunity to do both: some PRs to the doctool were merged while we were working on repo migration and we will need to migrate those as well. Since this will anyway disrupt everyone's in-flight branches, we might as well fix the indentation everywhere and ensure we keep it consistent this time.

bishabosha added a commit to dotty-staging/dotty that referenced this issue Nov 2, 2020
bishabosha added a commit that referenced this issue Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants