Skip to content

bump sbt-dotty and sbt versions #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

SethTisue
Copy link
Member

latest sbt-dotty requires sbt 1.4.x

@SethTisue
Copy link
Member Author

@anatoliykmetyuk are there some sbt-dotty release steps somewhere, that "update the version in https://github.com/scala/scala3-example-project" could be added to?

@SethTisue
Copy link
Member Author

CI tests both 3.0.0-M2 and "latest Scala nightly", but the code doesn't compile on the latest Scala nightly because the syntax for given has changed. so I think this PR is mergeable regardless. We can update the code once 3.0.0-M3 comes out.

Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "sbt-dotty release steps" are just creating a tag in the main Dotty repo which follows the pattern of previous SBT tags. But we release the SBT plugin separately from the standard release procedure when the need arises.

Otherwise LGTM, modulo changes already present in #48.

latest sbt-dotty requires sbt 1.4.x
This was referenced Dec 17, 2020
@SethTisue SethTisue self-assigned this Dec 17, 2020
@SethTisue SethTisue merged commit 353ccef into scala:master Dec 17, 2020
@SethTisue SethTisue deleted the version-bumps branch December 17, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants