Travis: replace broken oraclejdk8 with openjdk8 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oraclejdk8 doesn't work any more (for licensing reasons?), but openjdk8 does. I confirmed this behavior on https://travis-ci.org/Blaisorblade/scala19_gadt_code/builds/542859151 vs https://travis-ci.org/Blaisorblade/scala19_gadt_code/builds/542859522.
|
Apparently oraclejdk8 could still work, but openjdk8 still seems safer. Referenceshttps://travis-ci.community/t/install-of-oracle-jdk-8-failing/3038 |
nicolasstucki
requested review from
smarter
and removed request for
nicolasstucki
|
@smarter, it looks like a change in polymorphic function types affected type lambdas which made the compilation fail. |
|
@nicolasstucki I think that's correct — but FWIW, this PR goes from "broken build" to "less broken build" ;-). |
|
I see |
nicolasstucki
approved these changes
Jun 27, 2019
37 tasks
anatoliykmetyuk
added a commit
to lampepfl/xml-interpolator
that referenced
this pull request
Jul 23, 2019
gorilskij
pushed a commit
to gorilskij/xml-interpolator
that referenced
this pull request
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oraclejdk8 doesn't work any more (for licensing reasons?), but openjdk8 does.
I confirmed this behavior on
https://travis-ci.org/Blaisorblade/scala19_gadt_code/builds/542859151 vs
https://travis-ci.org/Blaisorblade/scala19_gadt_code/builds/542859522.
This PR gets an error, but that's a genuine one (on nightly), due to the syntax changes for type lambdas.