Improve efficiency of dead code checks #6617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the checkDead module out of Typer
- Use a new bit in ContextMode to track when to suppress
the warning, rather than maintaining the stack of the
symbols of enclosing applications
- Only do any of this when under -Ywarn-dead code
References scala/scala-dev#501
retronym
force-pushed
the
faster/checkdead
branch
from
f6e3a4e to
fc72bbb
Compare
|
|
SethTisue
added
the
performance
adriaanm
approved these changes
May 15, 2018
|
Would be nice to factor out the stuff from checkDead to probably a single method or two in context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the warning, rather than maintaining the stack of the
symbols of enclosing applications
References scala/scala-dev#501