Obey messaging in sbt-bridge #10503
Merged
Obey messaging in sbt-bridge #10503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
commented
Aug 17, 2023
| @@ -231,8 +235,7 @@ private final class DelegatingReporter( | |||
| } | |||
| } | |||
|
|
|||
| protected def info0(pos: Position, msg: String, rawSeverity: Severity, force: Boolean): Unit = | |||
| doReport(pos, msg, rawSeverity, Nil) | |||
| //protected def info0(pos: Position, msg: String, rawSeverity: Severity, force: Boolean): Unit = doReport(pos, msg, rawSeverity, Nil) | |||
SethTisue
added
the
internal
lrytz
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
👍 thank you!
I had a couple of cleanups / improvements in the previous attempt, see the commits at the bottom of https://github.com/scala/scala/pull/8531/commits (31d2f05 and down). But maybe it's better to get 2.13.12 out as-is. We'll have a smaller scope to consider in case problems appear with the binary bridge.
|
I did not do any research, but just tried to quiet warnings. It's probably undertested, as I see nontrivial LOC in red. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do what the warnings tell me to do.