More JDK 21 fixes #10403
Merged
More JDK 21 fixes #10403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SethTisue
commented
May 18, 2023
SethTisue
commented
- fix a warning on JDK 21
- for now, skip TASTy tests on JDK 21
they won't pass until we're using a Scala 3 release that has a fix for scala/bug#12783
SethTisue
added
the
internal
|
Forever 21! |
|
we'll see how https://github.com/scala/scala/actions/runs/5018243645 does with these changes @som-snytt if only Seth version 21 was LTS and I could downgrade to that edition whenever I wanted |
|
Yes, most people prefer to stick with Long Term Seth as a known quantity. (Or quality.) |
|
Yay, green! Thus concludes the JDK 21 work... except for the Scala 3 port. And the community build testing. |
|
Green as Seth at 21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.