Skip to content

Revert "Do not include partest and it's dependencies in generated pom." #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2013

Conversation

gkossakowski
Copy link
Contributor

This reverts commit 053193f merged in #7.

I misunderstood bevaior of test scope/configuration in relation to
transitive dependency. Partest can be included in generated pom as
long as it's declared to be in test scope. Therefore the changes
in 053193f are not needed.

This reverts commit 053193f.

I misunderstood bevaior of test scope/configuration in relation to
transitive dependency. Partest can be included in generated pom as
long as it's declared to be in test scope. Therefore the changes
in 053193f are not needed.
@gkossakowski
Copy link
Contributor Author

Review by @retronym.

@retronym
Copy link
Member

LGTM.

Even though they don't cause any real problems, perhaps we should actually consider stripping out test-scoped from the POMs we publish for the modules. Why expose an implementation detail like the test framework we use in this artifact. It is pure noise for someone reading that file.

But if we do that, we should do it uniformly for all our modules with shared configuration in @jsuereth's proposed scala-module SBT plugin.

retronym added a commit that referenced this pull request Oct 23, 2013
Revert "Do not include partest and it's dependencies in generated pom."
@retronym retronym merged commit dc7897f into scala:master Oct 23, 2013
@gkossakowski gkossakowski deleted the revert-partest-deps branch October 23, 2013 15:07
@gkossakowski
Copy link
Contributor Author

@retronym: I agree. Actually, my idea was to try those techniques I introduced 053193f in the small and test them whether they work as expected. Once battle tested I was planning to codify them in sbt plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants