Fix #51 Test compat for -Xxml:coalescing #61
Conversation
Rather than maintain a test to compile under multiple regimes, just build under `-Xxml:coalescing`. A few other flags are supplied. Deprecation is not yet possible because of `WordExp` et al. Renamed test classes `A` and `B` because sometimes it's nice to have a type parameter called `A` or `B`.
|
Apparently ScalaDoc warning messages fail under |
|
@som-snytt, we need to add -Xadriaanm-give-some-love-to-scala-xml . Alas we are ageing hipster minority. @adriaanm |
|
Once 2.12.0-M2 is out, I'll spend some loving attention on this. I'd like to coordinate with getting rid of the hack in scala/scala#4614 |
|
Sorry you had to hack, @adriaanm . The goal is surely to get high-value targets like yourself out of the module loop, and let maintainers maintain. Just touching this PR, I was overcome by the stench of bit rot. I also got a taste of my own medicine around the scalac options and spurious warnings. It definitely satisfied my hankering and maybe put me off it for ever. |
|
The patient is grateful for the firm hand -- thanks for holding your nose and ripping it all out. |
|
thanks @som-snytt, this was extremely helpful, as I didn't know any of the history on this. superseded now by #64 (which just adds some commits on top of yours) |
Rather than maintain a test to compile under multiple
regimes, just build under
-Xxml:coalescing.A few other flags are supplied. Deprecation is not yet
possible because of
WordExpet al. Renamed test classesAandBbecause sometimes it's nice to have a typeparameter called
AorB.-Xlint:stars-alignmust be off until 2.12.0-M2 arrives with scala/scala#4537.This tests for me with version 2.12, but I couldn't get it to fail, either, so I hope @adriaanm will verify at least with eyeballs.
Review by @biswanaths
Isn't it supposed to autocomplete the maintainer's name?