Update SBT Modules Version #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isomarcte
added a commit
to isomarcte/scala-xml
that referenced
this pull request
Sep 20, 2020
Though JDK16 is not yet released, building with it now will give us warnings about issues such as failure to build on JDK15 (scala#450)
isomarcte
added a commit
to isomarcte/scala-xml
that referenced
this pull request
Sep 20, 2020
Though JDK16 is not yet released, building with it now will give us warnings about issues such as failure to build on JDK15 (scala#450) Also adds the `osgiBundle` task to CI to catch issues with it.
isomarcte
added a commit
to isomarcte/scala-xml
that referenced
this pull request
Sep 20, 2020
Though JDK16 is not yet released, building with it now will give us warnings about issues such as failure to build on JDK15 (scala#450) Also adds the `osgiBundle` task to CI to catch issues with it.
Prior to this commit this project fails to build on JRE 15 due to an issue in a transitive dependency of `sbt-scala-module`. Attempting will yield this error. ``` [error] java.util.ConcurrentModificationException [error] at java.base/java.util.TreeMap.callMappingFunctionWithCheck(TreeMap.java:742) [error] at java.base/java.util.TreeMap.computeIfAbsent(TreeMap.java:596) [error] at aQute.bnd.osgi.Jar.putResource(Jar.java:288) [error] at aQute.bnd.osgi.Jar.buildFromZip(Jar.java:216) [error] at aQute.bnd.osgi.Jar.<init>(Jar.java:122) [error] at aQute.bnd.osgi.Jar.<init>(Jar.java:148) [error] at aQute.bnd.osgi.Analyzer.setClasspath(Analyzer.java:1597) [error] at com.typesafe.sbt.osgi.Osgi$.bundleTask(Osgi.scala:57) [error] at com.typesafe.sbt.osgi.SbtOsgi$.$anonfun$defaultOsgiSettings$1(SbtOsgi.scala:55) [error] at scala.Function1.$anonfun$compose$1(Function1.scala:49) [error] at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62) [error] at sbt.std.Transform$$anon$4.work(Transform.scala:67) [error] at sbt.Execute.$anonfun$submit$2(Execute.scala:281) [error] at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:19) [error] at sbt.Execute.work(Execute.scala:290) [error] at sbt.Execute.$anonfun$submit$1(Execute.scala:281) [error] at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178) [error] at sbt.CompletionService$$anon$2.call(CompletionService.scala:37) [error] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) [error] at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [error] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) [error] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) [error] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) [error] at java.base/java.lang.Thread.run(Thread.java:832) [error] (xml / osgiBundle) java.util.ConcurrentModificationException ``` See, * bndtools/bnd#3903 * sbt/sbt-osgi#72 * scala/sbt-scala-module#102
SethTisue
force-pushed
the
update-sbt-module-version
branch
from
e64d76c to
45fcec4
Compare
|
Thank you! And note that with scala/community-build#1225 , I hope to start catching this kind of thing sooner. |
SethTisue
pushed a commit
to isomarcte/scala-xml
that referenced
this pull request
Sep 30, 2020
Though JDK16 is not yet released, building with it now will give us warnings about issues such as failure to build on JDK15 (scala#450) Also adds the `osgiBundle` task to CI to catch issues with it.
isomarcte
added a commit
to isomarcte/scala-xml
that referenced
this pull request
Nov 30, 2020
Though JDK16 is not yet released, building with it now will give us warnings about issues such as failure to build on JDK15 (scala#450) Also adds the `osgiBundle` task to CI to catch issues with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit this project fails to build on JRE 15 due to an issue in a transitive dependency of
sbt-scala-module. Attempting will yield this error.See,
Note: This PR should not be merged, nor will it build, until scala/sbt-scala-module#102 is merged and
sbt-scala-moduledoes a release.