SI-8523 Adjust test for namespace interpolation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fails after we try to fix SI-8523 in the compiler. But the test is actually at fault here, as it was relying on the loose matching performed by the compiler's SymbolXMLBuilder. The fix for SI-8523 that triggered the failure: scala/scala@8d175b907 The original commit that introduced this test: scala/scala@e1ffc05b10be6
|
LGTM I'm impressed by the test coverage. I'm using this pair of PRs to demonstrate that you can fix such bugs in a point release without deprecation. The original issue was https://issues.scala-lang.org/browse/SI-486 which didn't ask for text nodes. Personally, I'm not totally clear on the use case for supplying a text node as an attribute value. I just decomposed some xml and I use the text node result (instead of |
|
FYI, digits were swapped in the SI-nembur. (It's SI-8253) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails after we try to fix SI-8523 in the compiler.
But the test is actually at fault here, as it was relying on
the loose matching performed by the compiler's SymbolXMLBuilder.
The fix for SI-8523 that triggered the failure:
scala/scala@8d175b907
The original commit that introduced this test:
scala/scala@e1ffc05b10be6
Review by @som-snytt