Fix null pointer exception in XhtmlParser #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make characters, including whitespace, after the `html' identifier in
<!DOCTYPE html> be optional. Otherwise, the following errors are
emitted:
file.xml:2:15: whitespace expected<html xmlns="http://www.w3.org/1999/xhtml"> ^
file.xml:2:15: document must contain exactly one element
And a java.lang.NullPointerException is thrown.
Unfortunately, testing with Source.fromString doesn't reproduce the
NullPointerException that occurs with Source.fromFile.
ashawley
force-pushed
the
fix-html5-npe
branch
from
2d362d6 to
61a2691
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259.
This one-line change seems low enough risk that it could be included in the next bug-fix release.