Skip to content

SI-4267 - fix to avoid XMLEventReader swallows IO/Parse exception #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2014

Conversation

dacr
Copy link
Contributor

@dacr dacr commented Mar 2, 2014

and so avoid threads leak and application that do not exit naturally.

@adriaanm
Copy link
Contributor

adriaanm commented Mar 8, 2014

Thanks, this will be included in the 1.0.1 release, which will be part of 2.11.0-RC2.

Next time, please keep the length of the commit title under 70 chars to avoid truncation.

SI-4267 avoid thread leak in XMLEventReader, don't swallow exceptions

Also, it would really help to have the commit message explain a bit more.
I still don't understand how this fix and the test are related by just looking at this PR.

I'll merge as-is because I really appreciate the work you've put in, and because I feel bad about the testing infrastructure fail :-)

adriaanm added a commit that referenced this pull request Mar 8, 2014
SI-4267 - fix to avoid XMLEventReader swallows IO/Parse exception
@adriaanm adriaanm merged commit c1db5fd into scala:master Mar 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants