scala.collection.mutable.Stack deprecated #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Using assertTrue and == won't show expected versus result.
shared/src/main/scala/scala/xml/dtd/impl/SubsetConstruction.scala:35: class Stack in package mutable is deprecated (since 2.12.0): Stack is an inelegant and potentially poorly-performing wrapper around List. Use a List assigned to a var instead.
val rest = new mutable.Stack[immutable.BitSet]
^
shared/src/main/scala/scala/xml/include/sax/XIncluder.scala:129: class Stack in package mutable is deprecated (since 2.12.0): Stack is an inelegant and potentially poorly-performing wrapper around List. Use a List assigned to a var instead.
private val entities = new mutable.Stack[String]()
^
shared/src/main/scala/scala/xml/parsing/FactoryAdapter.scala:42: class Stack in package mutable is deprecated (since 2.12.0): Stack is an inelegant and potentially poorly-performing wrapper around List. Use a List assigned to a var instead.
val attribStack = new mutable.Stack[MetaData]
^
shared/src/main/scala/scala/xml/parsing/FactoryAdapter.scala:43: class Stack in package mutable is deprecated (since 2.12.0): Stack is an inelegant and potentially poorly-performing wrapper around List. Use a List assigned to a var instead.
val hStack = new mutable.Stack[Node] // [ element ] contains siblings
^
shared/src/main/scala/scala/xml/parsing/FactoryAdapter.scala:44: class Stack in package mutable is deprecated (since 2.12.0): Stack is an inelegant and potentially poorly-performing wrapper around List. Use a List assigned to a var instead.
val tagStack = new mutable.Stack[String]
^
shared/src/main/scala/scala/xml/parsing/FactoryAdapter.scala:45: class Stack in package mutable is deprecated (since 2.12.0): Stack is an inelegant and potentially poorly-performing wrapper around List. Use a List assigned to a var instead.
var scopeStack = new mutable.Stack[NamespaceBinding]
^
Maybe just whitelist binary incompatabilities instead with mimaBinaryIssueFilters? https://github.com/typesafehub/migration-manager/wiki/sbt-plugin
I think breaking bincompat here would be fine. |
Merged
|
replaced by #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala 2.12 produces warnings about deprecations, there are others, but this is a particular brutal one.
Convert uses of
mutable.Stacktoimmutable.Listandvar.I've tried to preserve binary compatability, by creating members that use
collection.mutable.Stack.apply, but I don't get the deprecation warnings. Must be only the constructor has deprecation warnings? Regardless, the changes to avoid mima complaining is fraudulent binary compatability: I created members of the type mima wants, but the values are not actually used. So if users dependended on these members in their code, this would break. I don't think this is very likely, because the code smells very much like internal accounting.Maybe we just change everything to
List, break bincompat, add entries tomimaBinaryIssueFiltersand call it fixed instead?