publish for Scala 2.13.0-M2? #65
Comments
|
@benhutchison are you able to take this on...? |
|
Yes, I'll have some time to look at it today
…On Fri, Oct 13, 2017 at 6:08 AM, Seth Tisue ***@***.***> wrote:
@benhutchison <https://github.com/benhutchison> are you able to take this
on...?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF05EcI6U8_GBd0zRs2JnGG3SnPBVjcks5srmOdgaJpZM4PsvPB>
.
|
|
@SethTisue As its my first time doing a swing release via github tag, can you please review before I publish tag: https://github.com/scala/scala-swing/releases/tag/untagged-5bbb87e29549f27b4329 |
|
@benhutchison it seems your draft would tag the current 2.0.x, which has moved ahead of 2.0.0, so I guess you'd better do a full 2.0.1 in this case. Just tagging the 2.0.0 revision (76e4ffc) won't work because it's missing some infrastructure. For |
|
Ok, please be patient - this is new to me and so Im going slowly rather
than make a mistake.
I wasn't able to create a release off commit ce14150
<ce14150>
in
the github UI, AFAICT it doesn't consider that SHA a "recent commit" any
more.
Alternately, I created a draft v2.0.1 release which should build against
2.13 M2. Im not certain about the `version` in build.sbt, its still got a
SNAPSHOT suffix, that seems to be intended and the github release number
overrides it.?
…On Fri, Oct 13, 2017 at 5:17 PM, Lukas Rytz ***@***.***> wrote:
@benhutchison <https://github.com/benhutchison> it seems your draft would
tag the current 2.0.x, which has moved ahead of 2.0.0, so I guess you'd
better do a full 2.0.1 in this case.
Just tagging the 2.0.0 revision (76e4ffc
<76e4ffc>)
won't work because it's missing some infrastructure. For v2.0.0#2.13.0-M1,
I cherry-picked the infra change on top of 2.0.0 and tagged that. So you
could use the same revision (ce14150
<ce14150>)
for v2.0.0#2.13.0-M2, that should work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF05FvVxuXhzQgSSt7FgkavmN0UwKjdks5srwCDgaJpZM4PsvPB>
.
|
|
The draft 2.0.1:
https://github.com/scala/scala-swing/releases/tag/untagged-1158048b2b76a89aeab4
On Sat, Oct 14, 2017 at 1:28 PM, Ben Hutchison <[email protected]>
wrote:
… Ok, please be patient - this is new to me and so Im going slowly rather
than make a mistake.
I wasn't able to create a release off commit ce14150
<ce14150> in
the github UI, AFAICT it doesn't consider that SHA a "recent commit" any
more.
Alternately, I created a draft v2.0.1 release which should build against
2.13 M2. Im not certain about the `version` in build.sbt, its still got a
SNAPSHOT suffix, that seems to be intended and the github release number
overrides it.?
On Fri, Oct 13, 2017 at 5:17 PM, Lukas Rytz ***@***.***>
wrote:
> @benhutchison <https://github.com/benhutchison> it seems your draft
> would tag the current 2.0.x, which has moved ahead of 2.0.0, so I guess
> you'd better do a full 2.0.1 in this case.
>
> Just tagging the 2.0.0 revision (76e4ffc
> <76e4ffc>)
> won't work because it's missing some infrastructure. For v2.0.0#2.13.0-M1,
> I cherry-picked the infra change on top of 2.0.0 and tagged that. So you
> could use the same revision (ce14150
> <ce14150>)
> for v2.0.0#2.13.0-M2, that should work.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#65 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAF05FvVxuXhzQgSSt7FgkavmN0UwKjdks5srwCDgaJpZM4PsvPB>
> .
>
|
👍 but also, I suspect every member of the Scala team has at least one botched module release to their name (I certainly do), so don't sweat it, the worst that can happen is we burn a version number. nbd.
correct in your draft release, the tag name is |
|
Ok, Ive published a release v2.0.1 and travis build OK.
In the release instructions it says "Log into https://oss.sonatype.org/ and
identify the staging repository"
The only credentials Ive got for sonatype are my personal creds, and I cant
find a scala-swing staging repo using those.
…-Ben
On Sun, Oct 15, 2017 at 3:53 PM, Seth Tisue ***@***.***> wrote:
Im not certain about the version in build.sbt, its still got a
SNAPSHOT suffix, that seems to be intended and the github release number
overrides it.
correct
in your draft release, the tag name is v2.0.1#2.13.0-M2, but I think it
should just be v2.0.1. the # thing is only needed when republishing an
already-published library version for a new Scala version. the default
behavior is to publish for all of the supported Scala versions — which is
what we want here, for 2.0.1 to be a real release
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF05EBNvSGh7JPn-l6ZGXzpQZ6QER3pks5ssY-vgaJpZM4PsvPB>
.
|
|
the Scala team pulls the final lever here using our org-wide credentials. I hit "Close" followed by "Release" in the Sonatype web UI just now, so the artifacts should be on their way to Maven Central. |
|
Thanks. release notes repo has a PR for this now.
…On Thu, Oct 19, 2017 at 8:17 AM, Seth Tisue ***@***.***> wrote:
the Scala team pulls the final lever here using our org-wide credentials.
I hit "Close" followed by "Release" in the Sonatype web UI just now, so
the artifacts should be on their way to Maven Central.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF05OmeG3cwQHS6kndmAUaZHlDA0XJKks5stmrVgaJpZM4PsvPB>
.
|
|
looks like we're done! thanks Ben! |
and once available, add to https://github.com/scala/make-release-notes/blob/2.13.x/projects-2.13.md
The text was updated successfully, but these errors were encountered: