Upgrade to Scala 2.11.0-M6. #6
Conversation
That entails tweaking dependencies once again. Hold your breath:
* we can't upgrade to new version of partest because it's not been
released yet; we can't release it first because scalacheck is needed
* therefore we are using the M5 version and then we have to exclude
all transitive dependencies that were built against M5; one such
dependency would be scala-compiler itself
* since we excluded all transitive dependencies we need to bring some
back: we add diffutils and scala-compiler but M6 version
All newly added dependencies are in "test" scope. I verified that nothing
leaks to a pom.xml.
|
Review by @adriaanm or @retronym. This PR analogous to scala/scala-xml#10. |
|
BTW. I only now noticed that parser-combinators has considerably less partest tests than xml. It'll be easier to migrate to JUnit (and remove dependency on partest) first. |
|
Do we actually need the new scalacheck version for our internal use as a partest dependency? Why not just make partest depend on scalacheck with an exclusion of parser-combinators? |
|
I don't understand the question. I can't cut a new release of partest because it depends on scalacheck. Scalachecks depends on parser-combinators so we need to start with them in order to unbreak the cycle. |
|
Wasn't ScalaTest already released already for M6, albeit with one wrong dependency? Anyway, I like your idea to change to JUnit to save these questions. |
|
Oh, I see what you mean (and I assume you wanted to say scalacheck). I'd like to not keep releasing anything against that broken (in terms of dependencies) release of scalacheck. I'd like to release xml and parser-combinators ASAP and unblock (proper) release of scalacheck, partest, scalatest, etc. I've been a little bit slow on fixing all those problems because I didn't feel I fully understand what's going on. Now I do. In any case, migration to JUnit will indeed make all those questions irrelevant so consider this PR a transient step. I'll work on JUnit migration this week. |
|
LGTM -- yes, let's move to junit asap |
Upgrade to Scala 2.11.0-M6.
That entails tweaking dependencies once again. Hold your breath:
released yet; we can't release it first because scalacheck is needed
all transitive dependencies that were built against M5; one such
dependency would be scala-compiler itself
back: we add diffutils and scala-compiler but M6 version
All newly added dependencies are in "test" scope. I verified that nothing
leaks to a pom.xml.