Skip to content

Misleading error message when using optional or repeatedly parser #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/scala/scala/util/parsing/combinator/Parsers.scala
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,7 @@ trait Parsers {
if (in1.atEnd)
s
else
lastNoSuccessVar.value filterNot { _.next.pos < in1.pos } getOrElse Failure("end of input expected", in1)
lastNoSuccessVar.value filterNot { _.next.pos < in1.pos } getOrElse Failure("end of input expected", in1)
case ns => lastNoSuccessVar.value.getOrElse(ns)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ trait RegexParsers extends Parsers {
override def err(msg: String) = ws(super.err(msg))

override def phrase[T](p: Parser[T]): Parser[T] =
super.phrase(p <~ opt("""\z""".r))
super.phrase(p)

/** Parse some prefix of reader `in` with parser `p`. */
def parse[T](p: Parser[T], in: Reader[Char]): ParseResult[T] =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,39 @@ class JavaTokenParsersTest {
parseFailure("with-s", 5)
// we♥scala
parseFailure("we\u2665scala", 3)
parseFailure("with space", 6)
parseFailure("with space", 5)
}

@Test
def repeatedlyParsesTest: Unit = {
object TestTokenParser extends JavaTokenParsers
import TestTokenParser._
val p = ident ~ "(?i)AND".r.*

val parseResult = parseAll(p, "start")
parseResult match {
case Success(r, _) =>
assertEquals("start", r._1)
assertEquals(0, r._2.size)
case _ => sys.error(parseResult.toString)
}

val parseResult1 = parseAll(p, "start start")
parseResult1 match {
case e @ Failure(message, next) =>
assertEquals(next.pos.column, 7)
assert(message.endsWith("string matching regex `(?i)AND' expected but `s' found"))
case _ => sys.error(parseResult1.toString)
}

val parseResult2 = parseAll(p, "start AND AND")
parseResult2 match {
case Success(r, _) =>
assertEquals("start", r._1)
assertEquals("AND AND", r._2.mkString(" "))
case _ => sys.error(parseResult2.toString)
}
}


}