Skip to content

remove deprecated stuff #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2017
Merged

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Mar 20, 2017

not ready for merge, because a coordinated change is needed
in scala/scala

fixes #11

@SethTisue
Copy link
Member Author

SethTisue commented Mar 20, 2017

in ParTrieMap.scala here, we call TrieMap#readRoot, which is deprecated in scala/scala not because it will cease to exist, but because it is slated to be made package-private

so I need to go actually make it package-private there first, and then depend on the resulting Scala version, before we can make the last deprecation warning go away here done

@SethTisue SethTisue self-assigned this Mar 20, 2017
@SethTisue SethTisue force-pushed the deprecation-cleanup branch from 433346a to 54d0317 Compare March 20, 2017 22:54
@SethTisue SethTisue changed the title WIP: remove deprecated stuff remove deprecated stuff Apr 4, 2017
fixes scala#11

bump Scala version so we get scala/scala#5788

also bump version to 0.1.2-SNAPSHOT since we've already published
0.1.1
@SethTisue SethTisue force-pushed the deprecation-cleanup branch from 54d0317 to 122c82d Compare April 4, 2017 01:34
@SethTisue SethTisue requested a review from szeiger April 4, 2017 01:34
@szeiger
Copy link
Contributor

szeiger commented Apr 4, 2017

The build failed due to non-existing scaladoc variables. Were there any changes in scala/scala that could cause this?

What's the problem with TrieMap#readRoot? We can still make it package-private in scala.collection even though we don't "own" this package in the OSGi / Java 9 modules sense.

@SethTisue
Copy link
Member Author

The build failed due to non-existing scaladoc variables. Were there any changes in scala/scala that could cause this?

very likely those were warnings before and now they're errors because I enabled -Xfatal-warnings but didn't remember to locally test how that would pan out for Scaladoc generation

as for the root cause of the warnings, I imagine it has to do with the repo split? or perhaps they're older than that.... the scala/scala build is a riot of warnings

@SethTisue
Copy link
Member Author

What's the problem with TrieMap#readRoot

It seems to me that it was resolved by scala/scala#5788.

@szeiger
Copy link
Contributor

szeiger commented Apr 4, 2017

Ah, makes sense. I remember seeing scaladoc warnings before.

@SethTisue SethTisue merged commit 13fb0ed into scala:master Apr 4, 2017
@SethTisue SethTisue deleted the deprecation-cleanup branch April 4, 2017 18:41
@jiminhsieh jiminhsieh mentioned this pull request Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix deprecation warnings
2 participants