-
Notifications
You must be signed in to change notification settings - Fork 18
Add IterableOps.groupFlatMap #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
opinions from @scala/collections crew? |
The new file will need to have the standard copyright notice that the other files have ("...Copyright EPFL and Lightbend..."). I'm afraid we'd be unable to accept the contribution otherwise. |
@SethTisue could you give some history (for the uninitiated) as to why the assignment to Lightbend is required? Obviously they play a central role in the Scala community generally, but it seems odd to me that a contribution to the Scala "core" should require copyright assignment to a private commercial entity, rather than just EPFL. |
The Scala copyright has been shared by EPFL + Lightbend since the company was founded (as Typesafe) in 2011. I didn't join the company until a few years later, so I wasn't involved when that was arranged. At the time, the company had a more central role in Scala's development. (We do still maintain Scala 2, and we also participate in the Scala 3 effort, as per https://scala-lang.org/community/#whos-behind-scala .) Regardless, I'm noticing that https://www.lightbend.com/contribute/cla/scala/current doesn't actually mention Lightbend, only EPFL. So if you wanted for your contribution to be only copyright EPFL and not also copyright Lightbend, that request might actually be granted, I don't know. I doubt Lightbend would care, but regardless, the request would have to be handled by the Scala Center. cc @julienrf |
https://contributors.scala-lang.org/t/lightbend-copyright-assignment-required-for-scala-contributions/6019 is a better place for any further discussion around copyright. |
re: copyright, see also #197 which adds the same Scala CLA requirement as the scala/scala and scala/scala3 repos have had from the beginning |
Just picking this back up (I happened to be mucking around with my local copy of this recently, and was reminded this PR was still here!) I am prepared to sign a CLA assigning copyright to EPFL. I am not prepared to sign a CLA assigning copyright to Lightbend / Akka. I suspect I'm not the only potential contributor in this position. How can we proceed from here? |
@ashleymercer as Seth said:
as a side note: I know we all hate Lightbend dba Akka for re-licensing their eponymous library, but universities are far more persnickety and unpleasant about IP law, and you should probably be more concerned about EPFL. |
Proposed addition of
IterableOps.groupFlatMap
. Some questions before this gets merged:IterableOnce
which would be more general, but I don't think it's possible to haveIterableOnceOps.groupFlatMap
since we need access toiterableFactory
for building the new collection?Fixes #135