Skip to content

Remove develepment version from footer #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2016
Merged

Remove develepment version from footer #539

merged 2 commits into from
Nov 18, 2016

Conversation

jarrodu
Copy link
Member

@jarrodu jarrodu commented Nov 17, 2016

fix for #532

Also note that I changed Stable to Current. I can change this back or to something else people prefer.

@SethTisue
Copy link
Member

I didn't have this idea until just now, but what do you think about replacing "Development version" with an "All versions" link that goes to http://www.scala-lang.org/download/all.html ?

@jarrodu
Copy link
Member Author

jarrodu commented Nov 17, 2016

Hey Seth. Yeah I can do that. Probably tomorrow though. :-)

@jarrodu
Copy link
Member Author

jarrodu commented Nov 18, 2016

We now have "Current Version" and "All Versions" in the footer.

I also ran grep -r site.devscalaversion . and did not get any hits. I think we are ready to go with this.

@heathermiller
Copy link
Member

LGTM! :)

@heathermiller
Copy link
Member

Thanks @jarrodwb!

@SethTisue SethTisue merged commit 880cf60 into scala:master Nov 18, 2016
@jarrodu jarrodu deleted the issue-532 branch November 19, 2016 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants